New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With this commit, the root-anchor provisioning machinery no longer uses g_rootdnsname #5873

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
2 participants
@ahupowerdns
Member

ahupowerdns commented Oct 29, 2017

g_rootdnsname which might not yet have been initialized when our global scope DNSSEC trust anchor initializing code runs. This broke DNSSEC validation with -flto.

I also audited the code for other global scope uses of g_rootdnsname and did not find any, but I did not look too hard.

This minimal fix is super safe for 4.1. A broader fix might be setting a __attribute__((init_priority(0)) on g_rootdnsname.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
With this commit, the root-anchor provisioning machinery no longer us…
…es g_rootdnsname which might not yet have been initialized. This broke DNSSEC validation with -flto.
@Habbie

Habbie approved these changes Oct 29, 2017

@ahupowerdns ahupowerdns merged commit d5b796e into PowerDNS:master Oct 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment