New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdnsutil: Warn if records in a zone are eclipsed #5879

Merged
merged 2 commits into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@pieterlexis
Member

pieterlexis commented Oct 30, 2017

Short description

Fixes #3059

This is the output when eclipsing happens:

../../pdns/pdns/pdnsutil --config-dir=. check-zone example.com
Oct 30 17:47:31 Reading random entropy from '/dev/urandom'
Oct 30 17:47:31 gsqlite3: connection to '/home/lieter/src/PowerDNS/pdns-conf/3/pdns.db' successful
Oct 30 17:47:31 gsqlite3: connection to '/home/lieter/src/PowerDNS/pdns-conf/3/pdns.db' successful
[Warning] 'eclipsed.example.com|A' in zone 'example.com' is eclipsed by the zone-cut at 'eclipsed.example.com'
[Warning] 'dsfsdfs.fffff.eclipsed.example.com|A' in zone 'example.com' is eclipsed by the zone-cut at 'eclipsed.example.com'
Checked 5 records of 'example.com', 0 errors, 2 warnings.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Show outdated Hide outdated pdns/pdnsutil.cc Outdated
Show outdated Hide outdated pdns/pdnsutil.cc Outdated
pdnsutil: Support DNAME in occlusion check
Rename eclipsed to occluded.
@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Oct 30, 2017

Member

Output now looks like this:

Oct 30 18:37:08 Reading random entropy from '/dev/urandom'
Oct 30 18:37:08 gsqlite3: connection to '/home/lieter/src/PowerDNS/pdns-conf/3/pdns.db' successful
Oct 30 18:37:08 gsqlite3: connection to '/home/lieter/src/PowerDNS/pdns-conf/3/pdns.db' successful
[Warning] 'eclipsed.example.com|A' in zone 'example.com' is occluded by a delegation at 'eclipsed.example.com'
[Warning] 'dsfsdfs.fffff.eclipsed.example.com|A' in zone 'example.com' is occluded by a delegation at 'eclipsed.example.com'
[Warning] 'record.dname.example.com|A' in zone 'example.com' is occluded by a DNAME at 'dname.example.com'
Checked 7 records of 'example.com', 0 errors, 3 warnings.
Member

pieterlexis commented Oct 30, 2017

Output now looks like this:

Oct 30 18:37:08 Reading random entropy from '/dev/urandom'
Oct 30 18:37:08 gsqlite3: connection to '/home/lieter/src/PowerDNS/pdns-conf/3/pdns.db' successful
Oct 30 18:37:08 gsqlite3: connection to '/home/lieter/src/PowerDNS/pdns-conf/3/pdns.db' successful
[Warning] 'eclipsed.example.com|A' in zone 'example.com' is occluded by a delegation at 'eclipsed.example.com'
[Warning] 'dsfsdfs.fffff.eclipsed.example.com|A' in zone 'example.com' is occluded by a delegation at 'eclipsed.example.com'
[Warning] 'record.dname.example.com|A' in zone 'example.com' is occluded by a DNAME at 'dname.example.com'
Checked 7 records of 'example.com', 0 errors, 3 warnings.

@pieterlexis pieterlexis merged commit 51ca9d3 into PowerDNS:master Nov 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:issue-3059-check-zone-warn-eclipse branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment