Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to disable IP_BIND_ADDRESS_NO_PORT. #5880

Merged
merged 2 commits into from Oct 31, 2017

Conversation

dmccombs
Copy link
Contributor

Short description

This adds the configuration option ipBindAddrNoPort for downstream servers to optionally disable IP_BIND_ADDRESS_NO_PORT if dnsdist was built with support for it. It defaults to true to maintain current behavior by default.

This addresses the problem when dnsdist was built on a kernel newer than 4.2, but is running (in my case, in a container) on a system with an older kernel version which does not support IP_BIND_ADDRESS_NO_PORT, causing TCP connections to immediately fail.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.2.x milestone Oct 31, 2017
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, it looks good! Just one nit in the documentation part.

@@ -224,6 +224,7 @@ Servers
tcpSendTimeout=NUM, -- The timeout (in seconds) of a TCP write attempt
tcpRecvTimeout=NUM, -- The timeout (in seconds) of a TCP read attempt
tcpFastOpen=BOOL, -- Whether to enable TCP Fast Open
ipBindAddrNoPort=BOOL, -- Whether to enable IP Bind Address No Port
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Whether to enable IP_BIND_ADDRESS_NO_PORT if available, default: true"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rgacogne. Updated with that documentation change.

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgacogne rgacogne merged commit e5d68d9 into PowerDNS:master Oct 31, 2017
rgacogne added a commit to rgacogne/pdns that referenced this pull request Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants