New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Split NODATA/NXDOMAIN NSEC wildcard denial proof of existence #5885

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Oct 31, 2017

Short description

Otherwise there is a very real risk that a NSEC will cover a more specific wildcard and we end up with what looks like a NXDOMAIN proof but is a NODATA one.

Fixes #5882.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Split NODATA/NXDOMAIN NSEC wildcard denial proof of existence
Otherwise there is a very real risk that a NSEC will cover a more
specific wildcard and we end up with what looks like a NXDOMAIN
proof but is a NODATA one.

@rgacogne rgacogne added this to the rec-4.1.0 milestone Oct 31, 2017

@pieterlexis pieterlexis merged commit e10769a into PowerDNS:master Nov 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-nodata-nsec-wildcard branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment