New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Fix incomplete validation of cached entries #5904

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Nov 3, 2017

Short description

When an entry retrieved from the cache or the negative cache has not been previously validated because the initial query did not ask for validation, we only validate answers if the current zone
state was Secure. This is fine, but we also need to update the state of the current query if the current zone is Insecure or Bogus, even though we don't need to validate the records.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Fix incomplete validation of cached entries
When an entry retrieved from the cache or the negative cache has
not been previously validated because the initial query did not
ask for validation, we only validate answers if the current zone
state was Secure. This is fine, but we also need to update the
state of the current query if the current zone is Insecure or Bogus,
even though we don't need to validate the records.

@rgacogne rgacogne added this to the rec-4.1.0 milestone Nov 3, 2017

@pieterlexis pieterlexis merged commit c6bb81d into PowerDNS:master Nov 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-validate-cached-insecure branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment