New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use _exit() when we really really want to exit, for example after a fatal error #5917

Merged
merged 2 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@ahupowerdns
Member

ahupowerdns commented Nov 7, 2017

Short description

This stops us dying while we die. A call to exit() will trigger destructors, which may paradoxically stop the process from exiting, taking down only one thread, but harming the rest of the process.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the auth-4.1.0 milestone Nov 7, 2017

@rgacogne

This comment has been minimized.

Show comment
Hide comment
@rgacogne

rgacogne Nov 7, 2017

Member

I see some nasty looking exit() calls in distributor.hh too, did you skip these on purpose?

Member

rgacogne commented Nov 7, 2017

I see some nasty looking exit() calls in distributor.hh too, did you skip these on purpose?

@pieterlexis pieterlexis merged commit 29950b1 into PowerDNS:master Nov 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment