New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in the recursor secpoll code, we ASSumed the TXT record would be the first record #5930

Merged
merged 2 commits into from Nov 8, 2017

Conversation

Projects
None yet
2 participants
@ahupowerdns
Member

ahupowerdns commented Nov 8, 2017

Short description

in the recursor secpoll code, we ASSumed the TXT record would be the first record first record we received. Sometimes it was the RRSIG, leading to a silent error, and no secpoll check. Fixed the assumption, added an error.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
in the recursor secpoll code, we ASSumed the TXT record would be the …
…first record we received. Sometimes it was the RRSIG, leading to a silent error, and no secpoll check. Fixed the assumption, added an error.
catch(std::exception& e)
{
L<<Logger::Error<<"Exception while performing security poll: "<<e.what()<<endl;
}

This comment has been minimized.

@rgacogne

rgacogne Nov 8, 2017

Member

We should probably keep catching other types of exceptions here, because it looks like a PDNSException for example would bubble up and terminate the thread.

@rgacogne

rgacogne Nov 8, 2017

Member

We should probably keep catching other types of exceptions here, because it looks like a PDNSException for example would bubble up and terminate the thread.

@ahupowerdns ahupowerdns merged commit 7d10e68 into PowerDNS:master Nov 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ahupowerdns ahupowerdns deleted the ahupowerdns:secpoll-order-agnostic branch Nov 8, 2017

Habbie added a commit that referenced this pull request Nov 30, 2017

Merge pull request #6014 from aerique/backport/5930-secpoll-order-agn…
…ostic

Backport #5930: secpoll order agnostic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment