New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check return value for all getTSIGKey calls #5933

Merged
merged 3 commits into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@pieterlexis
Member

pieterlexis commented Nov 9, 2017

Short description

This would lead to crashes if the TSIG key was referenced in TSIG-ALLOW-FROM but the key was not in the tsigkeys table.

Closes #5931

I do need to add some regression tests, but need to have a good look at how.

Note: some unchecked calls to B64Decode remain in the code, these will be fixed in another PR.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Show outdated Hide outdated pdns/mastercommunicator.cc Outdated

@aerique aerique added this to the auth-4.1.0 milestone Nov 10, 2017

pieterlexis added some commits Nov 9, 2017

Check return value of getTSIGKey and B64Decode
This would lead to crashes if the TSIG key was referenced in
TSIG-ALLOW-FROM but the key was not in the tsigkeys table.

Closes #5931

@aerique aerique merged commit db73b59 into PowerDNS:master Nov 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:issue-5931-tsig-crash branch Nov 16, 2017

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment