New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Allow the use of a 'self-resolving' NS if cached A/AAAA exists #5937

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Nov 9, 2017

Short description

We just have to take care not to try to contact that NS to learn its own IP addresses, because that does not make sense. Before this, we could skip a perfectly valid NS for which we had retrieved the A and/or AAAA entries, for example via a glue.

Also get rid of a flawed calculation based on whether IPv6 was enabled whereas we were only dealing with NS at this point.

Should fix #2758.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Allow the use of a 'self-resolving' NS if cached A/AAAA exists
We just have to take care not to try to contact that NS to learn
its own IP addresses, because that does not make sense.
Before this, we could skip a perfectly valid NS for which we had
retrieved the A and/or AAAA entries, for example via a glue.
Also get rid of a flawed calculation based on whether IPv6 was
enabled whereas we were only dealing with NS at this point.

@rgacogne rgacogne added this to the rec-4.1.0 milestone Nov 9, 2017

@aerique aerique requested review from pieterlexis and ahupowerdns Nov 10, 2017

@ahupowerdns ahupowerdns merged commit e32853a into PowerDNS:master Nov 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-self-resolving-ns branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment