New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit configname definition to include the 'config-name' argument #5961

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
3 participants
@jake2184
Contributor

jake2184 commented Nov 15, 2017

Short description

Add the config-name argument to the definition of configname.

There was a bug where the config-name parameter was not used to change the path of the config file. This meant that some commands via rec_control (e.g. reload-acls) would fail when run against a recursor which had config-name defined. The correct behaviour was present in some, but not all, definitions of configname.

This PR adds the existing correct behaviour to 2 more places.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.0 milestone Nov 15, 2017

@aerique aerique merged commit 8641027 into PowerDNS:master Nov 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 21, 2017

@rgacogne rgacogne referenced this pull request Nov 21, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment