Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add burst option to MaxQPSIPRule #5970

Merged
merged 2 commits into from Nov 22, 2017
Merged

dnsdist: Add burst option to MaxQPSIPRule #5970

merged 2 commits into from Nov 22, 2017

Conversation

@42wim
Copy link
Contributor

@42wim 42wim commented Nov 17, 2017

Short description

Add burst option to MaxQPSIPRule

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne added this to the dnsdist-1.3.0 milestone Nov 21, 2017
Copy link
Member

@rgacogne rgacogne left a comment

Thank you for this PR! One nit, looks good otherwise.


Matches traffic for a subnet specified by ``v4Mask`` or ``v6Mask`` exceeding ``qps`` queries per second
Matches traffic for a subnet specified by ``v4Mask`` or ``v6Mask`` exceeding ``qps`` queries per second upto ``burst`` allowed

This comment has been minimized.

@rgacogne

rgacogne Nov 21, 2017
Member

It looks like a space is missing between up and to.

@rgacogne rgacogne merged commit fa99065 into PowerDNS:master Nov 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.