Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Keep the TCP connection open on cache hit, generated answers #6012

Merged
merged 1 commit into from Dec 5, 2017

Conversation

rgacogne
Copy link
Member

Short description

We used to close the TCP connection right away on cases where that did not make sense:

  • on a cache hit
  • on a self-generated answer
  • on a servfail answer caused by the lack of usable downstream servers

We still close the TCP connections on drops, dynamic blocks, lack of usable downstream servers without setServFailWhenNoServer() set, invalid queries, network errors..

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

We used to close the TCP connection right away on cases where that did
not make sense:
- on a cache hit
- on a self-generated answer
- on a servfail answer caused by the lack of usable downstream servers

We still close the TCP connections on drops, dynamic blocks, lack of
usable downstream servers without `setServFailWhenNoServer()` set,
invalid queries, network errors..
@zeha
Copy link
Collaborator

zeha commented Nov 28, 2017

LGTM

@rgacogne rgacogne merged commit 0ebca61 into PowerDNS:master Dec 5, 2017
@rgacogne rgacogne deleted the dnsdist-tcp-ka branch December 5, 2017 13:39
rgacogne added a commit to rgacogne/pdns that referenced this pull request Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants