Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add simple dnstap logging #6170

Merged
merged 2 commits into from Feb 5, 2018
Merged

dnsdist: Add simple dnstap logging #6170

merged 2 commits into from Feb 5, 2018

Conversation

@zeha
Copy link
Collaborator

@zeha zeha commented Jan 11, 2018

Short description

Adds a simple version of http://dnstap.info logging to dnsdist. Can use FrameStreamLogger or RemoteLogger with DnstapLogAction/DnstapLogResponseAction. Can use libfstrm TCP code if present.

Based off @jvalentini's PR.

Moves queryTime from DNSResponse to DNSQuestion.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@zeha zeha requested a review from rgacogne Jan 11, 2018
@zeha zeha force-pushed the zeha:dnstap branch 5 times, most recently from e3bd4fd to bfe5fef Jan 11, 2018
@zeha zeha mentioned this pull request Jan 15, 2018
4 of 6 tasks complete
@zeha zeha force-pushed the zeha:dnstap branch 4 times, most recently from 19d47bd to 5c7382d Jan 22, 2018
@zeha zeha force-pushed the zeha:dnstap branch from 5c7382d to ede23b8 Jan 23, 2018
@zeha zeha changed the title WIP: dnsdist: Add simple dnstap logging dnsdist: Add simple dnstap logging Jan 23, 2018
@zeha zeha force-pushed the zeha:dnstap branch from 15a6003 to 3e40d9c Jan 23, 2018
Based on a PR by Justin Valentini <jvalentini@dyn.com>.
@zeha zeha force-pushed the zeha:dnstap branch from 9e04323 to 82a91dd Jan 25, 2018
@zeha zeha added this to the dnsdist-1.3.0 milestone Jan 25, 2018
@zeha
Copy link
Collaborator Author

@zeha zeha commented Feb 5, 2018

@Habbie @pieterlexis we've discussed this a bit at FOSDEM, maybe one of you can have a look + possibly merge it, thx :)

@ahupowerdns ahupowerdns merged commit ad3e187 into PowerDNS:master Feb 5, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zeha zeha deleted the zeha:dnstap branch Feb 19, 2018
@rgacogne rgacogne mentioned this pull request Mar 22, 2018
1 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.