New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix building without libssl #6177

Merged
merged 3 commits into from Jan 15, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Jan 12, 2018

Short description

  • Only fail if DNS over TLS is enabled and we don't have either GnuTLS or OpenSSL libssl
  • Switch GnuTLS to auto, we will detect it but should only link it if DNS over TLS is enabled

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.0 milestone Jan 12, 2018

@zeha

zeha approved these changes Jan 12, 2018 edited

Tested, WFM.

Tiny (un)related nit, configure help mentions s2n:

  --enable-dns-over-tls   enable DNS over TLS support (require OpenSSL or s2n)
                          [default=no]
@rgacogne

This comment has been minimized.

Member

rgacogne commented Jan 15, 2018

Tiny (un)related nit, configure help mentions s2n

Nice catch, fixed!

@rgacogne rgacogne merged commit 6951ba1 into PowerDNS:master Jan 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-libssl branch Jan 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment