Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: run self-answered responses through a ruleset #6185

Merged
merged 2 commits into from Jan 23, 2018

Conversation

@zeha
Copy link
Collaborator

@zeha zeha commented Jan 15, 2018

Short description

Add a new ruleset for locally generated responses ("self-answered queries"). Previously those were impossible to run ResponseActions on, possibly for logging.
ServFail-on-no-policy responses are handled, too.

PR #6170 is a bit useless without this.

Docs are probably not the nicest.

Reviewers: I wasn't too sure which sizes to pass to processQuery at some points.

Fixes #6182.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@zeha zeha force-pushed the zeha:selfanswered-rules branch from e2d2eab to 5b9028c Jan 15, 2018
@zeha zeha requested a review from rgacogne Jan 16, 2018
Copy link
Member

@rgacogne rgacogne left a comment

Looks good, huge love for the refactoring!

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 16, 2018

Please note that this PR will conflict heavily with #6030. It absolutely does not mean it shouldn't be merged, but we should think a bit about the order in which we merge them.

@zeha
Copy link
Collaborator Author

@zeha zeha commented Jan 16, 2018

I'm happy to rebase this, but sooner is better than later :)

@zeha zeha added this to the dnsdist-1.3.0 milestone Jan 16, 2018
@zeha zeha force-pushed the zeha:selfanswered-rules branch from 5b9028c to 66c169a Jan 22, 2018
@zeha zeha force-pushed the zeha:selfanswered-rules branch from 66c169a to 2d4783a Jan 22, 2018
@zeha
Copy link
Collaborator Author

@zeha zeha commented Jan 22, 2018

Rebased, also took the refactor to the next level.

@pieterlexis pieterlexis merged commit a0401ed into PowerDNS:master Jan 23, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zeha zeha deleted the zeha:selfanswered-rules branch Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants