Add support for encrypting IP addresses #gdpr #6242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, PowerDNS core gains ability to encrypt & decrypt IP addresses as described in https://medium.com/@bert.hubert/on-ip-address-encryption-security-analysis-with-respect-for-privacy-dabe1201b476 For IPv4 this uses ipcrypt, for IPv6 it uses a 128-bit AES ECB operation. This CR also hooks up ipencrypt() and ipdecrypt() methods for dnsdist use, specifically to pseudonomyse logging.
rgacogne
requested changes
Feb 12, 2018
LGTM, just one nit regarding dnsdist's linkage.
| @@ -152,14 +152,13 @@ if HAVE_RE2 | |||
| dnsdist_LDADD += $(RE2_LIBS) | |||
| endif | |||
|
|
|||
| if HAVE_DNS_OVER_TLS | |||
There was a problem hiding this comment.
This would cause dnsdist to be linked against libgnutls and $(LIBSSL_LIBS) when they are available, regardless of whether DNS over TLS support is enabled. If I'm not mistaken you only need to link against $(LIBCRYPTO_LIBS) for this to work?
There was a problem hiding this comment.
yes, that is correct, but I did not find a way to make that happen correctly.
| @@ -52,10 +52,11 @@ PDNS_CHECK_LUA_HPP | |||
| DNSDIST_ENABLE_DNS_OVER_TLS | |||
| DNSDIST_CHECK_GNUTLS | |||
| DNSDIST_CHECK_LIBSSL | |||
| PDNS_CHECK_LIBCRYPTO | |||
| AS_IF([test "x$enable_dns_over_tls" != "xno"], [ | |||
| AS_IF([test "$HAVE_LIBSSL" = "1"], [ | |||
| # we need libcrypto if libssl is enabled | |||
There was a problem hiding this comment.
This comment is now useless
7 tasks
|
Superseded by #7481. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
With this change, PowerDNS core gains ability to encrypt & decrypt IP addresses as described in https://medium.com/@bert.hubert/on-ip-address-encryption-security-analysis-with-respect-for-privacy-dabe1201b476
For IPv4 this uses ipcrypt, for IPv6 it uses a 128-bit AES ECB operation.
This PR also hooks up ipencrypt() and ipdecrypt() methods for dnsdist use, specifically to pseudonomyse logging.
Checklist
I have:
The text was updated successfully, but these errors were encountered: