New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Count a lookup into an internal auth zone as a cache miss #6313

Merged
merged 3 commits into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Feb 28, 2018

Short description

We only considered a query a cache miss if we had to do at least one outgoing query, but having to look up into one of the internally hosted zone (auth-zones) should count as a cache miss too.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Count a lookup into an internal auth zone as a cache miss
We only considered a query a cache miss if we had to do at least
one outgoing query, but having to look up into one of the internally
hosted zone (auth-zones) should count as a cache miss too.

@rgacogne rgacogne added this to the rec-4.1.x milestone Feb 28, 2018

@rgacogne rgacogne requested a review from pieterlexis Feb 28, 2018

@pieterlexis

One small thing. Looks good otherwise. Perhaps we should expose this counter as a metric later as well?

@@ -697,6 +697,7 @@ public:
std::unordered_map<std::string,bool> d_discardedPolicies;
DNSFilterEngine::Policy d_appliedPolicy;
unsigned int d_authzonequeries;

This comment has been minimized.

@pieterlexis

pieterlexis Feb 28, 2018

Member

This variable should be initialized here

rgacogne added some commits Feb 28, 2018

@rgacogne

This comment has been minimized.

Member

rgacogne commented Feb 28, 2018

Fixed the initialized member issue (thanks!) and added the corresponding metric.

@rgacogne rgacogne merged commit 9923cbd into PowerDNS:master Mar 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-auth-zone-cache-miss branch Mar 1, 2018

rgacogne added a commit to rgacogne/pdns that referenced this pull request May 16, 2018

@rgacogne rgacogne referenced this pull request May 16, 2018

Merged

rec: backport #6562, #6566, #6567 and #6588 to 4.1.x #6612

2 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment