Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Metric "server-up" Count to Carbon Reporting #6327
This PR adds a metric (
Regression Test Output:
Thanks for this PR! A couple suggestions, and I think we can merge this quickly. As happy as I am to see trailing spaces go, please remove them in a separate commit whenever possible. It makes reviewing and especially looking for a specific changes later much more painful otherwise.
@rgacogne - Sorry about including the whitespace in that commit, happy to reset and commit that change separately if you like. Good call on the configuration for the regression test, it was feeling like a little much and turns out it was.
Thanks for the quick feedback, let me know if there is something else you'd like me to address.
Thanks for updating! A couple nits, looks good otherwise.