Dnsdist prometheus stats #6343
Closed
Dnsdist prometheus stats #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that Travis failures are unrelated to this PR. |
|
Code looks good at first glance, perhaps @wojas could chime in (no rush) to look at the Prometheus part? |
|
had a quick look -> ❤️ |
dannyk81
reviewed
Mar 29, 2018
| @@ -128,7 +128,7 @@ static bool isAnAPIRequestAllowedWithWebAuth(const YaHTTP::Request& req) | |||
|
|
|||
| static bool isAStatsRequest(const YaHTTP::Request& req) | |||
| { | |||
| return req.url.path == "/jsonstat"; | |||
| return req.url.path == "/jsonstat" || req.url.path == "/prometheus"; | |||
There was a problem hiding this comment.
Really looking forward for this to be merged!!! 👍 🙌
This is not really a big deal, but Prometheus default to /metrics for metrics path, would be nice to stick to the standard /metrics unless there's a reason no to.
# The HTTP resource path on which to fetch metrics from targets.
[ metrics_path: <path> | default = /metrics ]
https://prometheus.io/docs/prometheus/latest/configuration/configuration/
|
Hello! Are you going to finish this work? That's very useful change and it can improve dnsdist deployment experience a lot. I can help with testing. |
|
Superseded by #6901 which includes this work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Rebase of the original PR#3935, which is disconnected, hence a new PR.
See discussion #4947, and more recently #6002 and #6088.
I think I'm terrible at C++, but here we go.
Checklist
I have: