New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Speed up the processing of large ring buffers #6350

Merged
merged 7 commits into from Mar 19, 2018

Conversation

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Mar 15, 2018

Short description

  • We kept track of the remote addresses for each StatNode entry, copying them around several times, while we never used them in dnsdist (dnsscope does)
  • The exceed* functions (or more precisely the filterScore() one) sorted their return based on the score. We didn't used that (undocumented) property, and it led to unneeded copy of entire maps
  • Use a reserve()'d unordered_map instead of a map for exceed* operations

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added some commits Mar 14, 2018

dnsdist: Don't keep track of the remote in StatNode
We don't use them (they are not even available from Lua) and it
becomes very painful when you have a lot of different remotes in
the ring buffers.

@rgacogne rgacogne merged commit 90cb19f into PowerDNS:master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-lua-inspection-perfs branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment