Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Remove the --daemon option #6394

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

rgacogne
Copy link
Member

Short description

We keep finding bugs with this option because we don't use it on a regular basis and most users run dnsdist under some kind of supervision anyway.

Closes #6329.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

We keep finding bugs with this option because we don't use it on a
regular basis and most users run dnsdist under some kind of
supervision anyway.
@rgacogne rgacogne added this to the dnsdist-1.3.0 milestone Mar 26, 2018
pdns/dnsdist.cc Outdated
acls += s;
}
infolog("ACL allowing queries from: %s", acls.c_str());
vinfolog("Running in the foreground");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure this message is still relevant

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right

@pieterlexis pieterlexis merged commit 0482aec into PowerDNS:master Mar 27, 2018
@rgacogne rgacogne deleted the dnsdist-daemon-removal branch March 27, 2018 14:08
@rgacogne rgacogne mentioned this pull request Mar 29, 2018
6 tasks
Habbie added a commit to Habbie/pdns that referenced this pull request Apr 2, 2018
Habbie added a commit to Habbie/pdns that referenced this pull request Apr 2, 2018
@Habbie Habbie mentioned this pull request Apr 2, 2018
7 tasks
zeha pushed a commit to zeha/pdns that referenced this pull request Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist loses remote logger thread on daemonizing (-d)
2 participants