Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Remove the --daemon option #6394

Merged
merged 2 commits into from Mar 27, 2018

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 26, 2018

Short description

We keep finding bugs with this option because we don't use it on a regular basis and most users run dnsdist under some kind of supervision anyway.

Closes #6329.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
We keep finding bugs with this option because we don't use it on a
regular basis and most users run dnsdist under some kind of
supervision anyway.
@rgacogne rgacogne added the dnsdist label Mar 26, 2018
@rgacogne rgacogne added this to the dnsdist-1.3.0 milestone Mar 26, 2018
acls += s;
}
infolog("ACL allowing queries from: %s", acls.c_str());
vinfolog("Running in the foreground");

This comment has been minimized.

@pieterlexis

pieterlexis Mar 26, 2018
Member

nit: not sure this message is still relevant

This comment has been minimized.

@rgacogne

rgacogne Mar 26, 2018
Author Member

Oh right

@pieterlexis pieterlexis merged commit 0482aec into PowerDNS:master Mar 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-daemon-removal branch Mar 27, 2018
@rgacogne rgacogne mentioned this pull request Mar 29, 2018
3 of 6 tasks complete
@pieterlexis pieterlexis mentioned this pull request Mar 30, 2018
2 of 6 tasks complete
Habbie added a commit to Habbie/pdns that referenced this pull request Apr 2, 2018
Habbie added a commit to Habbie/pdns that referenced this pull request Apr 2, 2018
@Habbie Habbie mentioned this pull request Apr 2, 2018
2 of 7 tasks complete
zeha added a commit to zeha/pdns that referenced this pull request Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.