Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Optionally add ECS for cache lookup when all backends are down #6400

Merged
merged 1 commit into from Mar 28, 2018
Merged

dnsdist: Optionally add ECS for cache lookup when all backends are down #6400

merged 1 commit into from Mar 28, 2018

Conversation

rgacogne
Copy link
Member

Short description

Add an option so that we add ECS information to the query before looking up the cache, even if no backend has been selected. This is useful when all backends in a pool use ECS, causing the cached entries to be hashed with ECS information.
Fixes #6098.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.0 milestone Mar 27, 2018
@rgacogne rgacogne merged commit f54d107 into PowerDNS:master Mar 28, 2018
@rgacogne rgacogne deleted the dnsdist-ecs-pool branch March 28, 2018 08:26
@rgacogne rgacogne mentioned this pull request Mar 29, 2018
Merged
6 tasks
@M4t7e M4t7e mentioned this pull request Apr 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.3.0
Development

Successfully merging this pull request may close these issues.

dnsdist packet cache is not working if all ECS enabled backend servers are down
1 participant
@rgacogne