Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Optionally add ECS for cache lookup when all backends are down #6400
Conversation
rgacogne
added
enhancement
dnsdist
labels
Mar 27, 2018
rgacogne
added this to the dnsdist-1.3.0 milestone
Mar 27, 2018
rgacogne
merged commit f54d107
into
PowerDNS:master
Mar 28, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
rgacogne
deleted the
rgacogne:dnsdist-ecs-pool
branch
Mar 28, 2018
M4t7e
referenced this pull request
Apr 16, 2018
Closed
dnsdist packet cache is not working if all ECS enabled backend servers are down #6098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgacogne commentedMar 27, 2018
Short description
Add an option so that we add
ECSinformation to the query before looking up the cache, even if no backend has been selected. This is useful when all backends in a pool useECS, causing the cached entries to be hashed withECSinformation.Fixes #6098.
Checklist
I have: