Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMove the EL6 dnsdist package to upstart #6426
Conversation
pieterlexis
added this to the dnsdist-1.3.x milestone
Mar 30, 2018
pieterlexis
requested a review
from
rgacogne
Mar 30, 2018
rgacogne
approved these changes
Mar 30, 2018
Notwithstanding the fact that I don't know much about upstart, this looks OK to me.
pieterlexis
merged commit 07e2c8a
into
PowerDNS:master
Mar 31, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
pieterlexis
deleted the
pieterlexis:dnsdist-el6-upstart
branch
Mar 31, 2018
| if [ "\$1" -ge "1" ] ; then | ||
| /sbin/service %{name} condrestart >/dev/null 2>&1 || : | ||
| if [ -x /sbin/initctl ] && /sbin/initctl status %{name} 2>/dev/null | grep -q 'running' ; then | ||
| /sbin/initctl stop %{name} > /dev/null 2>&1 || : |
This comment has been minimized.
This comment has been minimized.
zeha
Apr 2, 2018
Collaborator
given this swallows all errors and it's a stop action, i don't see much point in calling initctl status first...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pieterlexis commentedMar 30, 2018
Short description
We forgot about this in #6394
Checklist
I have: