Skip to content

Move the EL6 dnsdist package to upstart #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2018

Conversation

pieterlexis
Copy link
Contributor

Short description

We forgot about this in #6394

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis added this to the dnsdist-1.3.x milestone Mar 30, 2018
@pieterlexis pieterlexis requested a review from rgacogne March 30, 2018 14:39
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notwithstanding the fact that I don't know much about upstart, this looks OK to me.

@pieterlexis pieterlexis merged commit 07e2c8a into PowerDNS:master Mar 31, 2018
@pieterlexis pieterlexis deleted the dnsdist-el6-upstart branch March 31, 2018 09:17
if [ "\$1" -ge "1" ] ; then
/sbin/service %{name} condrestart >/dev/null 2>&1 || :
if [ -x /sbin/initctl ] && /sbin/initctl status %{name} 2>/dev/null | grep -q 'running' ; then
/sbin/initctl stop %{name} > /dev/null 2>&1 || :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given this swallows all errors and it's a stop action, i don't see much point in calling initctl status first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants