Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: remove -d flag after #6394 #6433

Closed
wants to merge 2 commits into from
Closed

Conversation

@Habbie
Copy link
Member

@Habbie Habbie commented Apr 2, 2018

Short description

#6394 forgot to remove this, leading to a silent non-daemonized startup when passing -d.

Question: should the switch block have a default: that complains loudly?

Question: is -s missing intentionally even if we use it as the key to match --supervised?

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
@Habbie Habbie changed the title dnsdist: remove -d flag after #6394 dnsdist: fix short flags Apr 2, 2018
@Habbie Habbie changed the title dnsdist: fix short flags dnsdist: remove -d flag after #6394 Apr 2, 2018
@Habbie Habbie force-pushed the Habbie:dnsdist-d-flag branch from 693af46 to c482569 Apr 2, 2018
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Apr 3, 2018
@rgacogne
Copy link
Member

@rgacogne rgacogne commented Apr 3, 2018

Oh, right, I indeed forgot to remove it! Note that #6394 also removed the pid option so p should go as well. I don't remember if -s was left out intentionally but as it's not a very likely option to use manually on the command line, perhaps we just didn't bother adding the short version?

@zeha
Copy link
Collaborator

@zeha zeha commented Apr 3, 2018

Would agree on not having -s.

@Habbie
Copy link
Member Author

@Habbie Habbie commented Apr 3, 2018

so p should go as well

pushed

@zeha zeha mentioned this pull request Apr 3, 2018
1 of 6 tasks complete
@Habbie
Copy link
Member Author

@Habbie Habbie commented Apr 3, 2018

Replaced by #6435

@Habbie Habbie closed this Apr 3, 2018
@Habbie Habbie deleted the Habbie:dnsdist-d-flag branch Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.