dnsdist cli option improvements #6435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please feel free to include 6433 in this one. |
|
Includes #6433 now! |
7 tasks
rgacogne
requested changes
Apr 3, 2018
pdns/dnsdist.cc
Outdated
| @@ -2082,9 +2084,9 @@ try | |||
| string optstring; | |||
| for(;;) { | |||
| #ifdef HAVE_LIBSODIUM | |||
| int c=getopt_long(argc, argv, "a:hcde:C:k:l:vp:g:u:V", longopts, &longindex); | |||
| int c=getopt_long(argc, argv, "a:hce:C:k:l:v:g:u:V", longopts, &longindex); | |||
There was a problem hiding this comment.
--verbose doesn't take any argument so the : after the v should go (same thing below).
|
plus more cleanup... |
rgacogne
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Tiny improvements to the available dnsdist program options, and the --help and --version output.
Intended to be on top of #6433, might need a rebase then.
Checklist
I have: