Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist cli option improvements #6435

Merged
merged 8 commits into from Apr 3, 2018
Merged

dnsdist cli option improvements #6435

merged 8 commits into from Apr 3, 2018

Conversation

@zeha
Copy link
Collaborator

@zeha zeha commented Apr 3, 2018

Short description

Tiny improvements to the available dnsdist program options, and the --help and --version output.

Intended to be on top of #6433, might need a rebase then.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@zeha zeha added the dnsdist label Apr 3, 2018
@Habbie
Copy link
Member

@Habbie Habbie commented Apr 3, 2018

Intended to be on top of #6433, might need a rebase then.

Please feel free to include 6433 in this one.

@rgacogne rgacogne added the enhancement label Apr 3, 2018
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Apr 3, 2018
@zeha zeha force-pushed the zeha:dnsdist-opts branch from 0143117 to b716532 Apr 3, 2018
@zeha
Copy link
Collaborator Author

@zeha zeha commented Apr 3, 2018

Includes #6433 now!

@Habbie Habbie mentioned this pull request Apr 3, 2018
2 of 7 tasks complete
Copy link
Member

@rgacogne rgacogne left a comment

Just a single nit, looks very good otherwise!

@@ -2082,9 +2084,9 @@ try
string optstring;
for(;;) {
#ifdef HAVE_LIBSODIUM
int c=getopt_long(argc, argv, "a:hcde:C:k:l:vp:g:u:V", longopts, &longindex);
int c=getopt_long(argc, argv, "a:hce:C:k:l:v:g:u:V", longopts, &longindex);

This comment has been minimized.

@rgacogne

rgacogne Apr 3, 2018
Member

--verbose doesn't take any argument so the : after the v should go (same thing below).

This comment has been minimized.

@zeha

zeha Apr 3, 2018
Author Collaborator

Fixed.

@zeha
Copy link
Collaborator Author

@zeha zeha commented Apr 3, 2018

plus more cleanup...

@rgacogne rgacogne merged commit 4c4e761 into PowerDNS:master Apr 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zeha zeha deleted the zeha:dnsdist-opts branch Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.