New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Don't account chained queries more than once #6465

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Apr 10, 2018

Short description

Hopefully fixes #6462, I haven't tested this exact case. Thanks to @phonedph1 for the report and the suggested fix!

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the rec-4.1.x milestone Apr 10, 2018

@rgacogne rgacogne requested a review from pieterlexis Apr 10, 2018

@phonedph1

This comment has been minimized.

Show comment
Hide comment
@phonedph1

phonedph1 Apr 10, 2018

Contributor

I tested this patch against 4.1.2 and found it indeed fixes the original behavior described, and very close to what I had come up with the other night.

Thanks @rgacogne !

Contributor

phonedph1 commented Apr 10, 2018

I tested this patch against 4.1.2 and found it indeed fixes the original behavior described, and very close to what I had come up with the other night.

Thanks @rgacogne !

@pieterlexis pieterlexis merged commit 84ca47d into PowerDNS:master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-chained-outqueries branch Apr 11, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 20, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 20, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 21, 2018

@pieterlexis pieterlexis referenced this pull request Aug 21, 2018

Merged

Recursor 4.1.4 backports #6867

4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment