New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we increase "dnssec-validations" counter even when running with process-no-validate #6467

Merged
merged 2 commits into from Apr 11, 2018

Conversation

Projects
None yet
3 participants
@ahupowerdns
Member

ahupowerdns commented Apr 11, 2018

Short description

aj reported that we increase "dnssec-validations" counter even when running with process-no-validate. This can be caused by us receiving queries for special names ('localhost', 'version.bind') which we explicitly mark as Insecure. This led our statistics to conclude a validation attempt had taken place.
This commit puts the update check behind 'shouldValidate()'.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

ahupowerdns added some commits Apr 11, 2018

aj reported that we increase "dnssec-validations" counter even when r…
…unning

with process-no-validate.  This can be caused by us receiving queries for
special names ('localhost', 'version.bind') which we explicitly mark as
Insecure. This led our statistics to conclude a validation attempt had taken place.
This commit puts the update check behind 'shouldValidate()'.

@rgacogne rgacogne added this to the rec-4.1.x milestone Apr 11, 2018

@pieterlexis pieterlexis merged commit 9a45386 into PowerDNS:master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rgacogne added a commit to rgacogne/pdns that referenced this pull request May 16, 2018

@rgacogne rgacogne referenced this pull request May 16, 2018

Merged

rec: backport #6562, #6566, #6567 and #6588 to 4.1.x #6612

2 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment