Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Be more permissive in wrandom tests, log values on failure #6502

merged 1 commit into from Apr 16, 2018


Copy link

Short description

Given that the weight of the first server is very close to the maximum and we only send 100 queries, it quite possible that the second one gets no query at all in testHighValueWRandom.
Switch to the lesser / greater assertions so we get the exact values in case of failure.


I have:

  • read the document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit 390f0e4 into PowerDNS:master Apr 16, 2018
@rgacogne rgacogne deleted the dnsdist-wrandom-tests branch April 16, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants