New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: have a global g_log (backport) #6516

Open
wants to merge 1 commit into
base: rel/auth-4.1.x
from

Conversation

Projects
None yet
3 participants
@pieterlexis
Member

pieterlexis commented Apr 19, 2018

Short description

Not really a backport, but a re-do because of too many conflicts.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@pieterlexis pieterlexis added the auth label Apr 19, 2018

@zeha

This comment has been minimized.

Collaborator

zeha commented Apr 19, 2018

is backporting this really a good idea...?

@Habbie

This comment has been minimized.

Member

Habbie commented Apr 19, 2018

is backporting this really a good idea...?

We don't compile against Boost 1.67.0 without it (or, perhaps, something like it).

https://github.com/freebsd/freebsd-ports/blob/6fa3dca03cf2/dns/dnsdist/files/patch-boost-1.67

Homebrew/homebrew-core#26812

@zeha

This comment has been minimized.

Collaborator

zeha commented Apr 19, 2018

We don't compile against Boost 1.67.0 without it (or, perhaps, something like it).

I see. Maybe 4.1 should carry the "ugly" fix to keep the diff between 4.1.x -> 4.1.y small, so patches from 4.1.y can be applied to earlier versions more easily.

@pieterlexis

This comment has been minimized.

Member

pieterlexis commented Apr 25, 2018

I see. Maybe 4.1 should carry the "ugly" fix to keep the diff between 4.1.x -> 4.1.y small, so patches from 4.1.y can be applied to earlier versions more easily.

patches to 4.1.y would come from master and would be harder to apply though

@Habbie Habbie added this to the auth-4.1.x milestone Apr 30, 2018

@Habbie Habbie referenced this pull request Apr 30, 2018

Merged

move includes around to avoid boost L conflict #6542

2 of 7 tasks complete

@Habbie Habbie referenced this pull request May 10, 2018

Merged

reorder includes to avoid Boost L conflict #6595

2 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment