Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: show droprate in API output #6563

Merged
merged 3 commits into from Jun 8, 2018

Conversation

@pieterlexis
Copy link
Member

@pieterlexis pieterlexis commented May 2, 2018

Short description

It seems that dropRate was not shown when getting server statistics. It can be handy to have them.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Copy link
Member

@rgacogne rgacogne left a comment

Looks good, perhaps you could also update the corresponding regression test?

pieterlexis added 2 commits May 29, 2018
Copy link
Member

@rgacogne rgacogne left a comment

LGTM!

@rgacogne rgacogne removed the needs-tests label Jun 8, 2018
@rgacogne rgacogne merged commit e776d6b into PowerDNS:master Jun 8, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details
@pieterlexis pieterlexis deleted the pieterlexis:dnsdist-droprate-in-API branch Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.