Add syntax to dns.proto to silence compilation warning. #6577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
approved these changes
May 7, 2018
Member
|
Related: dnstap/dnstap.pb#4 |
Member
|
Why the auth-4.2.0 milestone? If I'm not mistaken this file is only used by dnsdist at the moment. |
Collaborator
|
I've -not- added any dnstap code to auth :) |
Member
Author
|
No specific reason for the milestone. Oh crap, I only now see that I added it to the auth milestone. Time to take a break :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Add syntax statement to
dnstap.protoas suggested by the compilation warning. This is the same default syntax statement the the protobuf compiler falls back to.This is just to get rid of the jarring warning message to comes by when compiling.
Checklist
I have: