Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax to dns.proto to silence compilation warning. #6577



Copy link

@aerique aerique commented May 7, 2018

Short description

Add syntax statement to dnstap.proto as suggested by the compilation warning. This is the same default syntax statement the the protobuf compiler falls back to.

This is just to get rid of the jarring warning message to comes by when compiling.


I have:

  • read the document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@aerique aerique added this to the auth-4.2.0 milestone May 7, 2018
@aerique aerique self-assigned this May 7, 2018
@aerique aerique requested a review from Habbie May 7, 2018 13:30
Copy link

rgacogne commented May 7, 2018

Related: dnstap/dnstap.pb#4

Copy link

rgacogne commented May 7, 2018

Why the auth-4.2.0 milestone? If I'm not mistaken this file is only used by dnsdist at the moment.

Copy link

zeha commented May 7, 2018

I've -not- added any dnstap code to auth :)

Copy link
Member Author

aerique commented May 7, 2018

No specific reason for the milestone. Perhaps we should give @jedisct1 the creds in the PR you referenced? Pff, I should really take a break.

Oh crap, I only now see that I added it to the auth milestone. Time to take a break :-(

@aerique aerique removed the request for review from Habbie May 7, 2018 14:14
@aerique aerique removed this from the auth-4.2.0 milestone May 8, 2018
@aerique aerique merged commit 6cfd368 into PowerDNS:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants