New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings reported by GCC 8.1.0 #6590

Merged
merged 1 commit into from May 10, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented May 9, 2018

Short description

  • polymorphic exceptions caught by value
  • ComboAddress objects manipulated via memset()

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Fix warnings reported by GCC 8.1.0
- polymorphic exceptions caught by value
- ComboAddress objects manipulated via `memset()`

@pieterlexis pieterlexis merged commit e876bc5 into PowerDNS:master May 10, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ 1 fixed alert
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@rgacogne rgacogne deleted the rgacogne:gcc-8-warnings branch May 10, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 20, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 20, 2018

@rgacogne rgacogne referenced this pull request Aug 22, 2018

Merged

Authoritative server 4.1.4 backports #6866

4 of 8 tasks complete

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment