New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-rdynamic is for the linker #6630

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
4 participants
@Habbie
Member

Habbie commented May 20, 2018

Short description

This moves -rdynamic from compiler to linker flags for the recursor. Ref #6511

I DID NOT test if the FFI symbols are correctly exported with this patch.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
@cmouse

This comment has been minimized.

Contributor

cmouse commented May 20, 2018

FWIW, I'd recommend replacing all instances of -rdynamic with -export-dynamic. This is a libtool specific flag (not to be confused with -Wl,-export-dynamic), that tells libtool that you want symbols to be exported. It is more portable way of achieving the same result.

@rgacogne

This comment has been minimized.

Member

rgacogne commented May 22, 2018

I DID NOT test if the FFI symbols are correctly exported with this patch.

I did, they are.

So I'm all for using -export-dynamicif it's more portable but I have no idea how to use it?

@rgacogne rgacogne added this to the rec-4.1.x milestone May 22, 2018

@Habbie

This comment has been minimized.

Member

Habbie commented May 22, 2018

So I'm all for using -export-dynamicif it's more portable but I have no idea how to use it?

I'll give this a shot.

@cmouse

This comment has been minimized.

Contributor

cmouse commented May 22, 2018

It works by setting
LDFLAGS=-export-dynamic

@Habbie

This comment has been minimized.

Member

Habbie commented May 22, 2018

Investigation shows that -rdynamic is portable to any platform on which GCC or Clang has been correctly built and configured, and the compiler will pass the right flags (if needed) to ld.

(Also, passing -export-dynamic in the right place would mean some ugly refactoring of configure.ac and Makefile.am).

So, let's just merge this.

@rgacogne rgacogne merged commit 941f490 into PowerDNS:master May 22, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@Habbie Habbie deleted the Habbie:rdynamic-ldflags branch May 22, 2018

@Habbie Habbie referenced this pull request May 22, 2018

Merged

-rdynamic is for the linker #6646

3 of 8 tasks complete

@pieterlexis pieterlexis referenced this pull request May 22, 2018

Merged

ChangeLog and secpoll update for rec 4.1.3 #6644

2 of 7 tasks complete

rgacogne added a commit to rgacogne/pdns that referenced this pull request May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment