New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy unitialized values of SuffixMatchTree #6637

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented May 21, 2018

Short description

Entries that are not endNodes are basically place-holder and don't have a valid value, so we shouldn't attempt to copy the value when we duplicate a node, or the whole tree.
Among other possible issues it triggers the Undefined Behavior Sanitizer:

dnsname.hh:236:126: runtime error: load of value 165, which is not a valid value for type 'bool'

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone May 21, 2018

@pieterlexis pieterlexis merged commit 61c1c08 into PowerDNS:master May 24, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@rgacogne rgacogne deleted the rgacogne:smt-uninit branch May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment