dnsdist: Fix reconnection handling #6672
Merged
Conversation
OP confirms that the packages built from this branch are fixing the issue for him. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
The first issue was that we closed the socket toward the backend if the first connection attempt failed, but tried to reconnect without reopening it, as reported by Aleš Rygl on the mailing-list 1.
The second issue is that we would close and reconnect the backend socket on some error codes even if the error was occurring on the health check socket, which is a separate one.
This PR also makes sure we don't try to reconnect from the healthcheck and responder threads at the same time, and that we don't accidentally start the same responder thread twice.
Checklist
I have: