Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Remove 'expired' states from MaxQPSIPRule #6674
Conversation
rgacogne
added
enhancement
dnsdist
labels
May 25, 2018
rgacogne
added this to the dnsdist-1.3.x milestone
May 25, 2018
pieterlexis
merged commit 2c2c104
into
PowerDNS:master
May 29, 2018
rgacogne
deleted the
rgacogne:dnsdist-clean-maxqpsip
branch
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgacogne commentedMay 25, 2018
Short description
The
MaxQPSIPRulerule needs to keep a state for seen source addresses. While this state is small we don't want to keep it for too long so this PR adds a cleaning mechanism that will remove entries that haven't been seen for a while. It also reduces the size of the state struct.Checklist
I have: