New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Remove 'expired' states from MaxQPSIPRule #6674

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented May 25, 2018

Short description

The MaxQPSIPRule rule needs to keep a state for seen source addresses. While this state is small we don't want to keep it for too long so this PR adds a cleaning mechanism that will remove entries that haven't been seen for a while. It also reduces the size of the state struct.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone May 25, 2018

@pieterlexis pieterlexis merged commit 2c2c104 into PowerDNS:master May 29, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-clean-maxqpsip branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment