Skip to content

Conversation

@zeha
Copy link
Collaborator

@zeha zeha commented May 28, 2018

Short description

For better introspection all creatable objects should have toString() methods. Actually many objects already have toString() implemented in C++, but then it's not hooked up to Lua.
This adds a few (easy) objects to Lua, obviously more would be better.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne self-requested a review May 28, 2018 14:14
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone May 28, 2018
@pieterlexis pieterlexis merged commit 261c04c into PowerDNS:master May 29, 2018
@zeha zeha deleted the dnsdist-tostring branch July 11, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants