New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Expose toString of various objects to Lua #6684

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
3 participants
@zeha
Collaborator

zeha commented May 28, 2018

Short description

For better introspection all creatable objects should have toString() methods. Actually many objects already have toString() implemented in C++, but then it's not hooked up to Lua.
This adds a few (easy) objects to Lua, obviously more would be better.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne self-requested a review May 28, 2018

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone May 28, 2018

@pieterlexis pieterlexis merged commit 261c04c into PowerDNS:master May 29, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@zeha zeha deleted the zeha:dnsdist-tostring branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment