dnsdist: Mark the remote member of DownstreamState as const #6688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
While investigating #6664, I noticed that we pass the
remote
member to functions that could alter it, likeSocket::recvFrom()
. At the moment I don't see how it could have led to having a different port in the end, since we use a connected socket, but it's still not very clean.As there is no reason to alter
remote
and some other members after the object construction, this PR marks them asconst
so we are prevented from passing them to a function that might alter their content.Checklist
I have: