Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
dnsdist: Support DNSAction.Allow in DynBlocks for testing purposes #6703
Supports DNSAction.Allow in DynBlocks for testing purposes, based on discussion in the IRC channel on 31/05. Also makes documentation more verbose.
changed the title from
Support DNSAction.Allow in DynBlocks for testing purposes
dnsdist: Support DNSAction.Allow in DynBlocks for testing purposes
Jun 2, 2018
Thank you for this pull request! Code looks pretty good. I'm a bit concerned about the fact that in this current version,
DNSAction.Allow definitively accepts the query, bypassing any rules. While this is consistent with the behavior of
DNSAction.Allow in other places, it does prevent using it to test
dynamic blocks if you also want the other rules to still apply. Perhaps we need a
DNSAction.NoOp or something like that?