Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic blocks were being created with the wrong duration #6706

Merged
merged 1 commit into from Jun 4, 2018
Merged

Dynamic blocks were being created with the wrong duration #6706

merged 1 commit into from Jun 4, 2018

Conversation

lochiiconnectivity
Copy link
Contributor

Dynamic blocks were being created with the wrong duration the detection interval was being used.

Short description

Fixes the duration as set at the creation of dynamic blocks from rules.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

rgacogne
rgacogne approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Jun 4, 2018
@rgacogne rgacogne merged commit 7b1cf12 into PowerDNS:master Jun 4, 2018
@rgacogne rgacogne mentioned this pull request Jun 5, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.3.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lochiiconnectivity @rgacogne