New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic blocks were being created with the wrong duration #6706

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@lochiiconnectivity
Contributor

lochiiconnectivity commented Jun 4, 2018

Dynamic blocks were being created with the wrong duration the detection interval was being used.

Short description

Fixes the duration as set at the creation of dynamic blocks from rules.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
David Freedman
@rgacogne

Looks good, thanks a lot!

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Jun 4, 2018

@rgacogne rgacogne merged commit 7b1cf12 into PowerDNS:master Jun 4, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@rgacogne rgacogne referenced this pull request Jun 5, 2018

Merged

dnsdist: Test the content of dynamic blocks using the API #6710

4 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment