dnsdist: default set "Connection: close" header for web requests #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
requested changes
Jun 5, 2018
pdns/dnsdist-web.cc
Outdated
| @@ -194,6 +194,7 @@ static void addSecurityHeaders(YaHTTP::Response& resp, const boost::optional<std | |||
| { "X-Permitted-Cross-Domain-Policies", "none" }, | |||
| { "X-XSS-Protection", "1; mode=block" }, | |||
| { "Content-Security-Policy", "default-src 'self'; style-src 'self' 'unsafe-inline'" }, | |||
| { "Connection", "close" }, | |||
There was a problem hiding this comment.
The name of the function (addSecurityHeaders) might not be relevant anymore after that change.
| @@ -21,6 +21,7 @@ By default, our web server sends some security-related headers:: | |||
| X-Permitted-Cross-Domain-Policies: none | |||
| X-XSS-Protection: 1; mode=block | |||
| Content-Security-Policy: default-src 'self'; style-src 'self' 'unsafe-inline' | |||
| Connection: close | |||
There was a problem hiding this comment.
I don't think Connection: close belongs here, it's not a security-related header at all.
|
Sorry, didn't pay attention to the name of the function. I did move setting the header where it cannot be overriden as we will always close the connection. |
rgacogne
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Short description
Default add the
Connection: closeheader to dnsdist http responses to indicate that the connection will be closed after completion of the response.Fix #6532
Checklist
I have: