Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Don't access the TCP buffer vector past its size #6716

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 5, 2018

Short description

The required memory has been reserve()'d, but we are not allowed to access it directly, and it breaks when compiled with the following flag, checking any access to containers as if .at() were used:

-D_GLIBCXX_ASSERTIONS

Fixes #6712.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The required memory has been reserve()'d, but we are not allowed to
access it directly, and it breaks when compiled with the following
flag, checking any access to containers as if .at() were used:

-D_GLIBCXX_ASSERTIONS
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Jun 5, 2018
@rgacogne rgacogne requested a review from chbruyand June 6, 2018 09:52
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgacogne rgacogne merged commit 17be415 into PowerDNS:master Jun 7, 2018
@rgacogne rgacogne deleted the dnsdist-tcp-vector-size branch June 7, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: sigabrt on Fedora 28
2 participants