Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add SetECSAction to set an arbitrary outgoing ECS value #6734

Merged
merged 2 commits into from Jul 9, 2018

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 13, 2018

Short description

Closes #6404.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Jun 13, 2018
@rgacogne rgacogne requested a review from chbruyand Jun 28, 2018
@rgacogne rgacogne modified the milestones: dnsdist-1.3.x, dnsdist-1.3.1 Jul 4, 2018
Copy link
Member

@chbruyand chbruyand left a comment

LGTM.

{
}

SetECSAction(Netmask v4, Netmask v6): d_v4(v4), d_v6(v6), d_hasV6(true)

This comment has been minimized.

@chbruyand

chbruyand Jul 6, 2018
Member

Couldn't we const & constructor arguments (here and with v4 only)?

This comment has been minimized.

@rgacogne

rgacogne Jul 9, 2018
Author Member

Done!

@rgacogne rgacogne merged commit 5a508e0 into PowerDNS:master Jul 9, 2018
4 checks passed
4 checks passed
LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-set-ecs branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.