New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add a negative TTL option to the packet cache #6740

Merged
merged 2 commits into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Jun 14, 2018

Short description

So it's possible to cap the TTL of NODATA and NXDOMAIN answers.
Also fixes a bug in the editTTLs() feature, where the wrong section was passed to the callback.

Closes #6579.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added some commits Jun 13, 2018

dnsdist: Add a negative TTL option to the packet cache
Also add unit tests for the standalone functions in dnsparser.cc

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Jun 14, 2018

@pieterlexis pieterlexis merged commit d64f1bd into PowerDNS:master Jun 21, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-packetcache-neg-ttl branch Jun 21, 2018

@@ -521,6 +524,7 @@ See :doc:`../guides/cache` for a how to.
:param bool dontAge: Don't reduce TTLs when serving from the cache. Use this when :program:`dnsdist` fronts a cluster of authoritative servers
:param int numberOfShards: Number of shards to divide the cache into, to reduce lock contention
:param bool deferrableInsertLock: Whether the cache should give up insertion if the lock is held by another thread, or simply wait to get the lock
:param bool maxNegativeTTL: Cache a NXDomain or NoData answer from the backend for at most this amount of seconds, even if the TTL of the SOA record is higher

This comment has been minimized.

@pr0vieh

pr0vieh Jul 10, 2018

i think this param must be an int not a bool just doc ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment