dnsdist: Add the ability to dump a summary of the cache content#6749
Merged
rgacogne merged 1 commit intoPowerDNS:masterfrom Jul 4, 2018
Merged
dnsdist: Add the ability to dump a summary of the cache content#6749rgacogne merged 1 commit intoPowerDNS:masterfrom
rgacogne merged 1 commit intoPowerDNS:masterfrom
Conversation
Contributor
|
This is much better than what I had come up with! |
Contributor
|
Looks good. Perhaps the TTL and QType should be swapped? Also, I would like a 'header' on the first line like this: |
Member
Author
I had the same feeling but decided to keep the same order than the one when dumping the recursor's packet cache. But the more I think about it, the less relevant it is so I'm OK with swapping it.
I'm not sure it's really needed, because that's almost what we already have: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The new feature writes a summary of the packet cache content to a file, dumping for each entry:
Checklist
I have: