New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuaWrapper: Disable maybe uninitialized warnings with boost optional #6769

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Jul 3, 2018

Short description

GCC enables -Wmaybe-uninitialized by default with -Wall, and it reports what looks like false positives with boost::optional types.

See:

I'm not a huge fan of hiding warnings, but these are flooding my terminal causing me to miss other, legitimate, warnings, and they look like false positives to me.
clang does not implement the warning and actually issue a warning if you try to hide a non-existent warning, so I had to exclude it.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
LuaWrapper: Disable maybe uninitialized warnings with boost optional
GCC enables `-Wmaybe-uninitialized` by default with `-Wall`, and it
reports what looks like false positives with boost::optional types

See:
- https://svn.boost.org/trac10/ticket/12513
- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78044
@zeha

zeha approved these changes Jul 3, 2018

@rgacogne rgacogne merged commit 9280f58 into PowerDNS:master Jul 9, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:luawrapper-maybe-uninitialized branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment