Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Implement NoneAction() #6775

Merged
merged 1 commit into from Jul 9, 2018
Merged

dnsdist: Implement NoneAction() #6775

merged 1 commit into from Jul 9, 2018

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 6, 2018 •
edited

Short description

The action has been documented at some point but never implemented, and it might be useful for testing purposes.
Closes #6758.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.1 milestone Jul 6, 2018
chbruyand
chbruyand approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgacogne rgacogne merged commit 24a2bcf into PowerDNS:master Jul 9, 2018
@rgacogne rgacogne deleted the dnsdist-none-action branch July 9, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.3.1
Development

Successfully merging this pull request may close these issues.

dnsdist: Implement NoneAction
2 participants
@rgacogne @chbruyand