Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add DNSAction.NoOp to debug Dynamic Blocks #6776

Merged
merged 2 commits into from Jul 9, 2018

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 6, 2018

Short description

Setting the dynamic block action to NoOp allows the dynamic rule to be inserted as usual and show up while looking at the rules, while not blocking any query and not stopping subsequent rules from
being evaluated. I pondered for a while not inserting any dynamic rule at all in that case, but we then log a lot of "inserting ..." lines as long as the condition is triggered, instead of just updating the existing dynamic rule.
Supersedes #6703 (thanks!).
CC @atosatto.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Setting the dynamic block action to NoOp allows the dynamic rule to
be inserted as usual and show up while looking at the rules,
while not blocking any query and not stopping subsequent rules from
being evaluated.
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgacogne rgacogne merged commit 18fe9e9 into PowerDNS:master Jul 9, 2018
@rgacogne rgacogne deleted the dnsdist-dynblock-noop branch July 9, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants