Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Display DynBlocks' default action, None, as the global one #6835

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Aug 8, 2018

Short description

The default action for a dynamic block is Action::None, which doesn't mean that nothing will be done but that the global action will be applied instead. We failed to display that correctly in the console and via the API.
Reported by ph1 (thanks!).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The default action for a dynamic block is Action::None, which doesn't
mean that nothing will be done but that the global action will be
applied instead. We failed to display that correctly in the console
and via the API.
@phonedph1
Copy link
Contributor

Nice! Thanks. Tested and works as expected now.

@rgacogne rgacogne merged commit 4c928be into PowerDNS:master Aug 9, 2018
@rgacogne rgacogne deleted the dnsdist-fix-dynblock-default-action-to-str branch August 9, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants