New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compiling against MySQL 8 client header files #6842

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
3 participants
@zeha
Collaborator

zeha commented Aug 10, 2018

Short description

MySQL 8 has removed the my_bool typedef. Just switching to bool would break compatibility with the 5.x headers.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@zeha zeha added this to the auth-4.2.0 milestone Aug 10, 2018

@Habbie Habbie self-requested a review Aug 10, 2018

@Habbie

Habbie approved these changes Aug 10, 2018

On my system:

  • master works with 5.7.21
  • this PR works with 5.7.21
  • master fails with 8.0.12
  • this PR works with 8.0.12

@Habbie Habbie merged commit 849c452 into PowerDNS:master Aug 10, 2018

3 of 4 checks passed

LGTM analysis: C/C++ Running analyses for revisions
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:mysql8 branch Aug 10, 2018

@zeha zeha referenced this pull request Aug 10, 2018

Merged

Workaround MariaDB pretending to be MySQL #6844

1 of 8 tasks complete

@pieterlexis pieterlexis referenced this pull request Aug 21, 2018

Merged

Authoritative server 4.1.4 backports #6866

4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment